From 4d857b386bebca7ceca3329ee1b76031d2303c35 Mon Sep 17 00:00:00 2001
From: 3252a8 <3252a8@proton.me>
Date: Mon, 25 May 2026 00:40:24 +0300
Subject: [PATCH] fix: remove inline startup panel sync

---
 backend/bot/main_bot.py        | 36 ----------------------------------
 tests/test_main_bot_startup.py | 24 +++++++++++++++++++++++
 2 files changed, 24 insertions(+), 36 deletions(-)

diff --git a/backend/bot/main_bot.py b/backend/bot/main_bot.py
index 7fec8b1..a9a7fab 100644
--- a/backend/bot/main_bot.py
+++ b/backend/bot/main_bot.py
@@ -5,16 +5,13 @@ from typing import Awaitable, Callable, Optional
 from aiogram import Bot, Dispatcher
 from aiogram.exceptions import TelegramNetworkError
 from aiogram.types import BotCommand, MenuButtonDefault, MenuButtonWebApp, WebAppInfo
-from sqlalchemy.orm import sessionmaker
 
 from bot.app.controllers.dispatcher_controller import build_dispatcher
 from bot.app.factories.build_services import build_core_services
 from bot.app.web.web_server import build_and_start_web_app
-from bot.handlers.admin.sync_admin import perform_sync
 from bot.infra.redis import close_redis
 from bot.middlewares.i18n import JsonI18n
 from bot.routers import build_root_router
-from bot.services.panel_api_service import PanelApiService
 from bot.services.settings_override_service import load_overrides_from_db
 from bot.utils.message_queue import init_queue_manager
 from config.settings import Settings
@@ -203,42 +200,9 @@ async def on_startup_configured(dispatcher: Dispatcher):
     except Exception:
         logging.exception("STARTUP: Failed to initialize message queue manager.")
 
-    # Automatic sync on startup — runs in background so the dispatcher can
-    # start serving Telegram webhooks immediately even if the panel is slow.
-    # perform_sync is single-flight, so concurrent admin-triggered runs will
-    # be skipped while this one is in progress.
     logging.info("STARTUP: Bot on_startup_configured completed.")
 
 
-async def _background_startup_sync(
-    *,
-    panel_service: PanelApiService,
-    session_factory: sessionmaker,
-    settings: Settings,
-    i18n_instance: JsonI18n,
-) -> None:
-    try:
-        async with session_factory() as session:
-            sync_result = await perform_sync(
-                panel_service=panel_service,
-                session=session,
-                settings=settings,
-                i18n_instance=i18n_instance,
-            )
-        status = sync_result.get("status")
-        details = sync_result.get("details", "N/A")
-        if status == "completed":
-            logging.info(f"STARTUP: Background sync completed successfully. Details: {details}")
-        elif status == "skipped":
-            logging.info(f"STARTUP: Background sync skipped: {details}")
-        else:
-            logging.warning(
-                f"STARTUP: Background sync finished with status '{status}'. Details: {details}"
-            )
-    except Exception:
-        logging.exception("STARTUP: Background sync failed.")
-
-
 async def on_shutdown_configured(dispatcher: Dispatcher):
     logging.warning("SHUTDOWN: on_shutdown_configured executing...")
 
diff --git a/tests/test_main_bot_startup.py b/tests/test_main_bot_startup.py
index c14cc5a..55eeefd 100644
--- a/tests/test_main_bot_startup.py
+++ b/tests/test_main_bot_startup.py
@@ -1,11 +1,35 @@
+import ast
 import asyncio
 import logging
+from pathlib import Path
 
 from aiogram.exceptions import TelegramNetworkError
 
 from bot.main_bot import _run_telegram_startup_step
 
 
+def test_backend_startup_does_not_run_panel_sync_inline():
+    source = Path("backend/bot/main_bot.py").read_text(encoding="utf-8")
+    tree = ast.parse(source)
+
+    forbidden_imports = [
+        node
+        for node in ast.walk(tree)
+        if isinstance(node, ast.ImportFrom)
+        and node.module == "bot.handlers.admin.sync_admin"
+    ]
+    forbidden_calls = [
+        node
+        for node in ast.walk(tree)
+        if isinstance(node, ast.Call)
+        and isinstance(node.func, ast.Name)
+        and node.func.id == "perform_sync"
+    ]
+
+    assert forbidden_imports == []
+    assert forbidden_calls == []
+
+
 def test_telegram_startup_network_error_retries_until_success_without_traceback(caplog):
     calls = []